Skip to content

Conversation

@RyanMullins
Copy link
Contributor

Description of the change

Fixes:

  • Hanging <td> tag in the links table
  • Incorrect derivation of CONFIG from VARIANT
  • Incorrect argument passed to get_model_config()
  • Common typo: "an PyTorch" should be "a PyTorch"

Motivation

Bug reported in google/gemma_pytorch#81 and tracked as http://b/419461706 internally.

Type of change

Choose one: Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@RyanMullins RyanMullins requested a review from a team as a code owner July 30, 2025 13:22
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Jul 30, 2025
@osanseviero osanseviero merged commit 5d19368 into google:main Jul 30, 2025
5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants